[Feature/extensions] CreateDetectorAction extends BaseExtensionRestHandler #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwiddis
force-pushed
the
baseresthandler
branch
2 times, most recently
from
609b9bf to
88c100e
Compare
owaiskazi19
approved these changes
Nov 15, 2022
|
@dbwiddis rebase with feature/extensions? |
ryanbogan
approved these changes
Nov 18, 2022
dbwiddis
force-pushed
the
baseresthandler
branch
from
88c100e to
caa5389
Compare
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
force-pushed
the
baseresthandler
branch
from
caa5389 to
2a3c89c
Compare
dbwiddis
commented
Nov 18, 2022
| public List<Route> routes() { | ||
| return List.of(new Route(POST, "/detectors")); | ||
| protected List<RouteHandler> routeHandlers() { | ||
| return List.of(new RouteHandler(POST, "/detectors", (r) -> handlePostRequest(r))); |
There was a problem hiding this comment.
@owaiskazi19 FYI, I tried to use the same shortened format as the RestHelloAction but the internal use of client and xContentRegistry inside a Function falls afoul of "must be final" (even though they are defined final!)
So I had to keep it as a standard method and do the lambda version of the Function inline here.
See here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Requires merging SDK #246 first.
Description
Simplifies
CreateDetectorActionby extendingBaseExtensionRestHandler:routes()torouteHandlers()which auto-checks the method and pathIssues Resolved
Fixes SDK #245
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.